KAFKA-18870 Implement describeDelegationToken for controller #19306
Conversation
github-actions
bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
| this.bootstrapControllerOpt = parser.accepts("bootstrap-controller", | ||
| "REQUIRED: A comma-separated list of bootstrap.controllers that can be supplied instead of bootstrap-servers." | ||
| + " This is useful for administrators who wish to bypass the brokers.") | ||
| .withRequiredArg() |
There was a problem hiding this comment.
You cannot specify both --bootstrap-server and --bootstrap-controller as required. This makes result like:
> ./bin/kafka-delegation-tokens.sh --bootstrap-controller localhost:9093 --describe
Missing required argument "[bootstrap-server]"
Please using withOptionalArg and do the check in checkArgs.
| serverProperties = { | ||
| @ClusterConfigProperty(key = DELEGATION_TOKEN_SECRET_KEY_CONFIG, value = "key") | ||
| }) | ||
| public void testDescribeDelegationTokenWithBootstrapController(ClusterInstance clusterInstance) throws ExecutionException, InterruptedException { |
There was a problem hiding this comment.
This test case is about Admin. We need another test case to test DelegationTokenCommand directly.
|
BTW, could you add some content to PR description? Thanks. |
| @@ -284,7 +294,7 @@ public String hmac() { | |||
|
|
|||
| public void checkArgs() { | |||
| // check required args | |||
| CommandLineUtils.checkRequiredArgs(parser, options, bootstrapServerOpt, commandConfigOpt); | |||
| CommandLineUtils.checkRequiredArgs(parser, options, commandConfigOpt); | |||
There was a problem hiding this comment.
Addressed https://github.com/apache/kafka/pull/19306/files#r2034702639 here.
Remaining checks can be done by CommandLineUtils.initializeBootstrapProperties
|
@johnny94 could you please fix the conflicts? |
|
@chia7712 Thanks. Fixed it. |
This PR includes
describeDelegationTokenAPIcontroller,
bootstrap.controllersandbootstrap.serverscannot be setat the same time